-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: remaining errors.Is conversions #18617
base: main
Are you sure you want to change the base?
server: remaining errors.Is conversions #18617
Conversation
Hi @redwrasse. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 16 files with indirect coverage changes @@ Coverage Diff @@
## main #18617 +/- ##
==========================================
+ Coverage 68.77% 68.80% +0.03%
==========================================
Files 420 420
Lines 35535 35539 +4
==========================================
+ Hits 24439 24454 +15
+ Misses 9666 9664 -2
+ Partials 1430 1421 -9 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, redwrasse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @redwrasse, thanks for your pull request. I think for this PR, we may be missing the following (but correct me if I'm wrong):
|
Thanks for flagging @ivanvc . Let me add those in here. |
5d242b0
to
f597415
Compare
Added in the additional lines. |
f597415
to
500b853
Compare
500b853
to
99b0465
Compare
@ivanc sorry, I messed this one up. I may not get to it until tomorrow, or feel free to make the changes yourself if you get the chance. |
No worries, we can wait (I don't think I'm even able to edit or add to a pull request 😃) |
99b0465
to
47cad30
Compare
@ivanc, I think I've got all cases of the server module. Could you let me know if you see anymore? Then I'll remove the draft status. |
Thanks, @redwrasse. It looks like you updated all the cases. Please remove the draft so we can see the CI result. |
@redwrasse, thanks for updating the pull request. With all the checks passing, can you squash your commits? 🙏 Thanks! |
Signed-off-by: redwrasse <[email protected]>
eaac0fc
to
0739142
Compare
Squashed commits! |
@redwrasse: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Remaining errors.Is conversions for
server
module, as part of #18576.